Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 758: Allow except and except* expressions without parentheses #4008

Merged
merged 5 commits into from
Oct 1, 2024
Merged

PEP 758: Allow except and except* expressions without parentheses #4008

merged 5 commits into from
Oct 1, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 30, 2024 •
edited
Loading

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--4008.org.readthedocs.build/

@pablogsal pablogsal requested a review from a team as a code owner September 30, 2024 22:12
JelleZijlstra
JelleZijlstra reviewed Sep 30, 2024
View reviewed changes
peps/numerical.rst Outdated Show resolved Hide resolved
JelleZijlstra
JelleZijlstra reviewed Sep 30, 2024
View reviewed changes
peps/pep-0790.rst Outdated Show resolved Hide resolved
hauntsaninja
hauntsaninja reviewed Sep 30, 2024
View reviewed changes
peps/pep-0790.rst Outdated Show resolved Hide resolved
AA-Turner
AA-Turner reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion about the title and several suggestions to use the code-block directive instead of orphaned ::.

It might be nice to cover except (...) as identifier: too.

Also, at an appropriate time before merging the document should be re-wrapped to 80 characters and yourself and Brett added to CODEOWNERS for PEP 790.

A

peps/pep-0790.rst Outdated Show resolved Hide resolved
peps/pep-0790.rst Outdated Show resolved Hide resolved
peps/pep-0790.rst Outdated Show resolved Hide resolved
peps/pep-0790.rst Outdated Show resolved Hide resolved
peps/pep-0790.rst Outdated Show resolved Hide resolved
peps/pep-0790.rst Outdated Show resolved Hide resolved
peps/pep-0790.rst Outdated Show resolved Hide resolved
peps/pep-0790.rst Outdated Show resolved Hide resolved
@hugovk hugovk added the new-pep A new draft PEP submitted for initial review label Oct 1, 2024
hugovk
hugovk reviewed Oct 1, 2024
View reviewed changes
peps/pep-0790.rst Outdated Show resolved Hide resolved
peps/pep-0790.rst Outdated Show resolved Hide resolved
brettcannon
brettcannon approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving as co-author.

@pablogsal @hugovk
Update peps/pep-0790.rst
3b2cbb5 
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
hugovk reviewed Oct 1, 2024
View reviewed changes
peps/pep-0790.rst Outdated Show resolved Hide resolved
@hugovk hugovk changed the title PEP 790: Removing the parentheses requirement from except expressions PEP 758: Removing the parentheses requirement from except expressions Oct 1, 2024
@AA-Turner AA-Turner changed the title PEP 758: Removing the parentheses requirement from except expressions PEP 758: Allow except and except* expressions without parentheses Oct 1, 2024
AlexWaygood
AlexWaygood approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PEP :-)

peps/pep-0758.rst Outdated Show resolved Hide resolved
@JelleZijlstra @AlexWaygood
Update peps/pep-0758.rst
e9c7c1a 
Co-authored-by: Alex Waygood <[email protected]>
@pablogsal pablogsal merged commit 668beb0 into python:main Oct 1, 2024
6 checks passed
@pablogsal pablogsal deleted the pep-790 branch October 1, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

@hugovk hugovk Awaiting requested review from hugovk

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pablogsal @brettcannon @JelleZijlstra @hugovk @AA-Turner @hauntsaninja @AlexWaygood